adnanhemani commented on code in PR #1586:
URL: https://github.com/apache/polaris/pull/1586#discussion_r2094163557
##########
polaris-core/src/main/java/org/apache/polaris/core/storage/StorageLocation.java:
##########
@@ -99,4 +111,23 @@ public boolean isChildOf(StorageLocation potentialParent) {
return slashTerminatedLocation.startsWith(slashTerminatedParentLocation);
}
}
+
+ private static String scheme(String location) {
+ int schemePos = location.indexOf(':');
+ if (schemePos > 0) {
+ return location.substring(0, schemePos).toLowerCase(Locale.ROOT);
+ }
+ return null;
+ }
+
+ protected String normalizePath(String path) {
Review Comment:
Seems like both terms are synonyms - at least I'm not seeing a difference
between these two terms. Can you please explain the difference or provide a
link to something that does? For reference, this is what
[Google](https://www.google.com/search?q=canonicalize+vs+normalize&client=safari&sca_esv=861d6c36a75495fa&rls=en&sxsrf=AHTn8zrDV0AEV8cAvsCBTIMeqtVihnblHw%3A1747499926443&ei=lrsoaMPtGvDokPIPoK2qqAU&ved=0ahUKEwjDkPHC-KqNAxVwNEQIHaCWClUQ4dUDCBA&oq=canonicalize+vs+normalize&gs_lp=Egxnd3Mtd2l6LXNlcnAiGWNhbm9uaWNhbGl6ZSB2cyBub3JtYWxpemUyChAAGLADGNYEGEcyChAAGLADGNYEGEcyChAAGLADGNYEGEcyChAAGLADGNYEGEcyChAAGLADGNYEGEcyChAAGLADGNYEGEcyChAAGLADGNYEGEcyChAAGLADGNYEGEdI2gdQAFgAcAF4AZABAJgBAKABAKoBALgBDMgBAJgCAaACCpgDAIgGAZAGCJIHATGgBwCyBwC4BwA&sclient=gws-wiz-serp)
is pulling up on this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
