eric-maynard commented on code in PR #1532:
URL: https://github.com/apache/polaris/pull/1532#discussion_r2086170234
##########
polaris-core/src/main/java/org/apache/polaris/core/config/FeatureConfiguration.java:
##########
@@ -234,4 +233,38 @@ public static void enforceFeatureEnabledOrThrow(
.description("If true, the policy-store endpoints are enabled")
.defaultValue(true)
.buildFeatureConfiguration();
+
+ public static final FeatureConfiguration<Boolean>
ALLOW_SPECIFYING_FILE_IO_IMPL =
+ PolarisConfiguration.<Boolean>builder()
+ .key("ALLOW_SPECIFYING_FILE_IO_IMPL")
+ .description(
+ "Config key for whether to allow setting the FILE_IO_IMPL using
catalog properties. "
+ + "Must only be enabled in dev/test environments, never in
production systems.")
+ .defaultValue(false)
+ .buildFeatureConfiguration();
+
+ public static final FeatureConfiguration<Boolean>
Review Comment:
I think you are (and maybe this PR is) conflating two things -- FILE storage
type and HadoopFileIO. They are not always the same.
`SUPPORTED_CATALOG_STORAGE_TYPES` is probably sufficient to disallow the
FILE storage type. `FILE` shouldn't be in the default, but I think it's too
great a leap to go from having it in the default to requiring multiple flags to
enable it.
For disallowing HadoopFileIO, we need a different approach than what's done
in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
