gh-yzou commented on code in PR #1505:
URL: https://github.com/apache/polaris/pull/1505#discussion_r2085489564
##########
quarkus/service/src/main/java/org/apache/polaris/service/quarkus/config/QuarkusFeaturesConfiguration.java:
##########
@@ -29,5 +30,11 @@ public interface QuarkusFeaturesConfiguration extends
FeaturesConfiguration {
Map<String, String> defaults();
@Override
- Map<String, FeaturesConfiguration.RealmOverrides> realmOverrides();
+ Map<String, QuarkusRealmOverrides> realmOverrides();
Review Comment:
Sorry, I was referring to this doc change
https://github.com/apache/polaris/pull/1511. i though it was describing that
the key is changing from "realm-overrides" to "overrides", I don't really mean
you are changing the key, sorry for the confusion. However, your change is
adding a new nested key "overrides" in the doc, and it seems we want to revert
back to the old behavior to only have the "realm-overrides" key. So i guess we
are all good here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
