snazy commented on code in PR #1555:
URL: https://github.com/apache/polaris/pull/1555#discussion_r2084890200
##########
extension/persistence/relational-jdbc/src/main/java/org/apache/polaris/extension/persistence/relational/jdbc/JdbcBasePersistenceImpl.java:
##########
@@ -414,6 +415,11 @@ public <T> Page<T> listEntities(
// Limit can't be pushed down, due to client side filtering
// absence of transaction.
String query = QueryGenerator.generateSelectQuery(new ModelEntity(),
params);
+
+ if (pageToken instanceof EntityIdPageToken entityIdPageToken) {
+ query += String.format(" AND id > %d ORDER BY id ASC",
entityIdPageToken.getId());
Review Comment:
I'd propose to change the Page/PageToken contract in a way to push the
parameter "as is" down to the persistence layer and let the persistence
implementation deal with it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
