pingtimeout commented on code in PR #1532:
URL: https://github.com/apache/polaris/pull/1532#discussion_r2084030683
##########
quarkus/service/src/main/java/org/apache/polaris/service/quarkus/config/ProductionReadinessChecks.java:
##########
@@ -55,26 +62,53 @@ public class ProductionReadinessChecks {
*/
private static final String WARNING_SIGN_UTF_8 = "\u0000\u26A0\uFE0F";
+ private static final String SEVERE_SIGN_UTF_8 = "\u0000\uD83D\uDED1";
Review Comment:
Let's be mindful on the overhead that too fine-grained PR would cause
though...
The changes in this PR are cohesive to one another. And it is quite small.
So it makes sense to submit the changes in a single PR. Splitting a PR into
many tiny PRs would prevent reviewers from understanding the big picture and
would not have any functional merit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
