flyrain commented on code in PR #1554:
URL: https://github.com/apache/polaris/pull/1554#discussion_r2083801384
##########
getting-started/jdbc/docker-compose-bootstrap-db.yml:
##########
@@ -22,11 +22,13 @@ services:
# IMPORTANT: the image MUST contain the Postgres JDBC driver and
EclipseLink dependencies, see README for instructions
image: apache/polaris-admin-tool:postgres-latest
environment:
- polaris.persistence.type: relational-jdbc
- quarkus.datasource.db-kind: pgsql
- quarkus.datasource.jdbc.url: jdbc:postgresql://postgres:5432/POLARIS
- quarkus.datasource.username: postgres
- quarkus.datasource.password: postgres
+ - JAVA_DEBUG=true
+ - JAVA_DEBUG_PORT='*:5005'
+ - POLARIS_PERSISTENCE_TYPE=relational-jdbc
+ - QUARKUS_DATASOURCE_DB_KIND=pgsql
Review Comment:
I guess these are default value. This is probably just for my information,
is it OK to ignore them? To be clear, I'm OK to keep them here.
##########
getting-started/jdbc/docker-compose-bootstrap-db.yml:
##########
@@ -22,11 +22,13 @@ services:
# IMPORTANT: the image MUST contain the Postgres JDBC driver and
EclipseLink dependencies, see README for instructions
Review Comment:
Minor: this comment seems unnecessary, as the jdbc related jars are within
docker image by default now.
##########
getting-started/jdbc/README.md:
##########
@@ -37,6 +37,7 @@ This example requires `jq` to be installed on your machine.
2. Start the docker compose group by running the following command from the
root of the repository:
```shell
+ export PG_JDBC_URL=jdbc:postgresql://postgres:5432/POLARIS
Review Comment:
Should we also export username and password outside of the docker composer?
Maybe just me, but feel a bit weird when we allow users to input URL while it
has the fixed username and password.
```
- QUARKUS_DATASOURCE_USERNAME=postgres
- QUARKUS_DATASOURCE_PASSWORD=postgres
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
