flyrain commented on code in PR #1564:
URL: https://github.com/apache/polaris/pull/1564#discussion_r2083320097
##########
extension/persistence/relational-jdbc/src/main/java/org/apache/polaris/extension/persistence/relational/jdbc/DatasourceOperations.java:
##########
@@ -96,20 +95,14 @@ public void executeScript(String scriptFilePath) throws
SQLException {
* @param query : Query to executed
* @param converterInstance : An instance of the type being selected, used
to convert to a
* business entity like PolarisBaseEntity
- * @param transformer Transformation of entity class to Result class
* @return The list of results yielded by the query
- * @param <T> : Persistence entity class
- * @param <R> : Business entity class
+ * @param <T> : Business entity class
* @throws SQLException : Exception during the query execution.
*/
- public <T, R> List<R> executeSelect(
- @Nonnull String query,
- @Nonnull Converter<T> converterInstance,
- @Nonnull Function<T, R> transformer)
Review Comment:
No transformer is required after this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
