flyrain commented on code in PR #1515:
URL: https://github.com/apache/polaris/pull/1515#discussion_r2074200699
##########
site/content/in-dev/unreleased/metastores.md:
##########
@@ -32,6 +32,29 @@ In order to add other JDBC drivers, you have to build
Polaris using the `eclipse
## Polaris Server Configuration
+### Relational JDBC
+Configure the `polaris.persistence` section in your Polaris configuration file
+(`application.properties`) as follows:
+
+```
+polaris.persistence.type=relational-jdbc
Review Comment:
Is it OK to miss as `relational-jdbc` should be the default value now?
##########
site/content/in-dev/unreleased/metastores.md:
##########
@@ -32,6 +32,29 @@ In order to add other JDBC drivers, you have to build
Polaris using the `eclipse
## Polaris Server Configuration
+### Relational JDBC
+Configure the `polaris.persistence` section in your Polaris configuration file
+(`application.properties`) as follows:
+
+```
+polaris.persistence.type=relational-jdbc
+
+quarkus.datasource.db-kind=postgresql
+quarkus.datasource.username=<your username>
+quarkus.datasource.password=<your password>
+
+quarkus.datasource.jdbc.url=jdbc:postgresql://localhost:5432/<database_name>
+```
+
+The relational JDBC metastore currently relies on a Quarkus-managed datasource
and supports only Postgres and H2—similar to EclipseLink. However, we only
provide documentation for using it with Postgres. In future releases of Apache
Polaris, we plan to extend support to additional RDBMS datasources such as
MySQL and MariaDB. These are not currently supported due to differences in
schema requirements and error handling conventions.
Review Comment:
Can we just say only Postgres and H2 are supported in Polaris due to the
schema differences? We may not put a plan in a usage doc.
##########
site/content/in-dev/unreleased/configuring-polaris-for-production.md:
##########
@@ -135,34 +135,32 @@ default, Polaris uses an in-memory metastore.
> The default in-memory metastore is not suitable for production use, as it
> will lose all data
> when the server is restarted; it is also unusable when multiple Polaris
> replicas are used.
-To use a durable metastore, you need to switch to the EclipseLink metastore,
and provide your own
-`persistence.xml` file. This file contains details of the database used for
metastore management and
-the connection settings. For more information, refer to the [metastore
documentation]({{% ref
-"metastores" %}}).
+To enable a durable metastore, configure your system to use the Relational
JDBC-backed metastore.
+This implementation leverages Quarkus for datasource management and supports
configuration through
+environment variables or JVM -D flags at startup. For more information, refer
to the [Quarkus configuration
reference](https://quarkus.io/guides/config-reference#env-file).
-Then, configure Polaris to use your metastore by setting the following
properties:
+Configure the metastore by setting the following ENV variables:
-```properties
-polaris.persistence.type=eclipse-link
-polaris.persistence.eclipselink.configuration-file=/path/to/persistence.xml
-polaris.persistence.eclipselink.persistence-unit=polaris
```
+POLARIS_PERSISTENCE_TYPE=relational-jdbc
-Where:
+QUARKUS_DATASOURCE_DB_KIND=postgresql
+QUARKUS_DATASOURCE_USERNAME=<your-username>
+QUARKUS_DATASOURCE_PASSWORD=<your-password>
+QUARKUS_DATASOURCE_JDBC_URL=<jdbc-url-of-postgres>
+```
Review Comment:
Both env variable and Quarkus `application.properties` work. Can we be
consistent about the configuration in the doc as the metastores.md use the
`application.properties` way? I think we can mention the
`application.properties` way here while refer to page
`https://polaris.apache.org/in-dev/unreleased/configuration/` if users prefer
env variable. Thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
