pingtimeout commented on PR #22: URL: https://github.com/apache/polaris-tools/pull/22#issuecomment-2846741704
This is quite interesting, thanks for raising this @eric-maynard ! I think it can be solved in better ways. The current fix consists in overwriting the header that Gatling puts, which feels not ideal. What you could do is: * Either replace `.check(status.is(200))` by `.check(status.in(200, 304))` call to make it clear that the HTTP 304 code is perfectly valid. That better conveys the intent that Polaris may return that code. This will be pulled by all simulations that fetch tables. * Or update the `httpProtocol` definition in `ReadTreeDataset` and `ReadUpdateTreeeDataset` and add `.disableCaching` so that Gatling does not include the `If-None-Match` header anymore. That effectively disables client caching and will force Polaris to return the full entity, leading to slightly more stress on the server. And this would apply to all read queries, like namespaces and views, without having to overwrite the header everywhere. I think `.disableCaching` is the way to go. Wdyt? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
