eric-maynard commented on code in PR #1504:
URL: https://github.com/apache/polaris/pull/1504#discussion_r2071265052
##########
polaris-core/src/main/java/org/apache/polaris/core/storage/IcebergStorageAccessProperty.java:
##########
@@ -18,15 +18,23 @@
*/
package org.apache.polaris.core.storage;
-/** Enum of polaris supported credential properties */
-public enum PolarisCredentialProperty {
+/**
+ * A subset of Iceberg catalog properties recognized by Polaris.
+ *
+ * <p>Most of these properties are meant to configure Iceberg FileIO objects
for accessing data in
+ * storage.
+ */
+public enum IcebergStorageAccessProperty {
AWS_KEY_ID(String.class, "s3.access-key-id", "the aws access key id"),
AWS_SECRET_KEY(String.class, "s3.secret-access-key", "the aws access key
secret"),
AWS_TOKEN(String.class, "s3.session-token", "the aws scoped access token"),
AWS_SESSION_TOKEN_EXPIRES_AT_MS(
String.class,
"s3.session-token-expires-at-ms",
"the time the aws session token expires, in milliseconds"),
+ AWS_ENDPOINT(String.class, "s3.endpoint", "the S3 endpoint to use for
requests", false),
+ AWS_PATH_STYLE_ACCESS(
+ Boolean.class, "s3.path-style-access", "whether to use S3 path style
access", false),
Review Comment:
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
