owenowenisme commented on code in PR #1471:
URL: https://github.com/apache/polaris/pull/1471#discussion_r2065714842
##########
site/content/in-dev/unreleased/getting-started/using-polaris.md:
##########
@@ -174,7 +174,7 @@ Replace the credentials used in the Docker container using
the following code:
```shell
USER_CLIENT_ID="XXXX"
USER_CLIENT_SECRET="YYYY"
-sed -i
"s/^\(.*spark\.sql\.catalog\.polaris\.credential=\).*/\1${USER_CLIENT_ID}:${USER_CLIENT_SECRET}\",/"
getting-started/eclipselink/docker-compose.yml
+sed -i
"s/^\(.*spark\.sql\.catalog\.quickstart_catalog\.credential=\).*/\1${USER_CLIENT_ID}:${USER_CLIENT_SECRET}\",/"
getting-started/eclipselink/docker-compose.yml
Review Comment:
I think you're right!
I think I can open another PR to use env variable instead.
WDYT?
##########
site/content/in-dev/unreleased/getting-started/using-polaris.md:
##########
@@ -174,7 +174,7 @@ Replace the credentials used in the Docker container using
the following code:
```shell
USER_CLIENT_ID="XXXX"
USER_CLIENT_SECRET="YYYY"
-sed -i
"s/^\(.*spark\.sql\.catalog\.polaris\.credential=\).*/\1${USER_CLIENT_ID}:${USER_CLIENT_SECRET}\",/"
getting-started/eclipselink/docker-compose.yml
+sed -i
"s/^\(.*spark\.sql\.catalog\.quickstart_catalog\.credential=\).*/\1${USER_CLIENT_ID}:${USER_CLIENT_SECRET}\",/"
getting-started/eclipselink/docker-compose.yml
Review Comment:
I think you're right!
I can open another PR to use env variable instead.
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
