singhpk234 commented on code in PR #1371:
URL: https://github.com/apache/polaris/pull/1371#discussion_r2061078233
##########
quarkus/admin/src/main/java/org/apache/polaris/admintool/config/QuarkusProducers.java:
##########
@@ -76,4 +81,13 @@ public PolarisConfigurationStore configurationStore() {
// A configuration store is not required when running the admin tool.
return new PolarisConfigurationStore() {};
}
+
+ @Produces
+ public List<DataSource> dataSources(@All List<InstanceHandle<DataSource>>
dataSources) {
Review Comment:
I tried that approach and it failed again, latest CI for reference :
https://github.com/apache/polaris/actions/runs/14675783807/job/41191690984?pr=1371
At this point given we clearly fail when > 1 DS is there and we don;t wanna
have Instance logic outside quarkus this parth looks reasonable to me,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
