mansehajsingh commented on code in PR #11:
URL: https://github.com/apache/polaris-tools/pull/11#discussion_r2057188950
##########
polaris-synchronizer/cli/src/main/java/org/apache/polaris/tools/sync/polaris/SyncPolarisCommand.java:
##########
@@ -120,11 +120,35 @@ public class SyncPolarisCommand implements
Callable<Integer> {
)
private boolean haltOnFailure;
+ @CommandLine.Option(
+ names = {"--delta-only"},
+ description = "Only synchronize the diff between the source and
target Polaris."
+ )
+ private boolean deltaOnly;
+
+ @CommandLine.Option(
+ names = {"--strategy"},
+ defaultValue = "CREATE_ONLY",
Review Comment:
Unfortunately, we can't use the enum value. I could declare a separate set
of constants for them that are assigned strings with the same value, if you
think that's worth adding for maintainability? Something like
```java
enum Strategy {
CREATE_ONLY,
...
class Names {
public static final String CREATE_ONLY = "CREATE_ONLY";
...
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
