dimas-b commented on code in PR #1430:
URL: https://github.com/apache/polaris/pull/1430#discussion_r2056701986
##########
extension/persistence/relational-jdbc/src/main/java/org/apache/polaris/extension/persistence/relational/jdbc/JdbcBasePersistenceImpl.java:
##########
@@ -122,7 +122,7 @@ public void writeEntity(
}
} catch (SQLException e) {
throw new RuntimeException(
- String.format("Failed to write entity due to %s", e.getMessage()));
+ String.format("Failed to write entity due to %s", e.getMessage()),
e);
Review Comment:
TBH, I do not see any immediate benefit of using a new exception type unless
we catch it specifically.
Let's merge this PR and if we have to catch (or do `instanceof`) JDBC
specific exceptions in the future, then we'll add those sub-types.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
