mansehajsingh commented on code in PR #1283:
URL: https://github.com/apache/polaris/pull/1283#discussion_r2055073205


##########
.github/workflows/gradle.yml:
##########
@@ -57,10 +57,10 @@ jobs:
           validate-wrappers: false
 
       - name: Code style checks and tests
-        run: ./gradlew --continue check
+        run: ./gradlew --continue check --no-build-cache

Review Comment:
   Iceberg API interfaces are autogenerated from the REST Spec using the 
`open-api-generator` gradle plugin. When `--no-build-cache` is not used, the CI 
is using the cached generated interfaces from before the REST spec change, and 
not regenerating the interfaces from the new REST spec. This means that any 
signatures etc. that should change on the interfaces don't update, and the 
build fails to compile in CI if anyone does implement those changes in the 
implementations of the Iceberg API interfaces to match the new generated 
interfaces locally.
   
   I wonder if there is any way to turn off caching for just the 
`openApiGenerate` tasks.
   
   Maybe adding the `outputs.cacheIf { false }` clause to those tasks? 
https://stackoverflow.com/questions/66988241/disable-remote-gradle-cache-for-one-task



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to