eric-maynard commented on code in PR #1405:
URL: https://github.com/apache/polaris/pull/1405#discussion_r2051400734
##########
service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalogHandler.java:
##########
@@ -1010,6 +1028,31 @@ public void renameView(RenameTableRequest request) {
CatalogHandlers.renameView(viewCatalog, request);
}
+ private @Nonnull LoadTableResponse filterResponseToSnapshots(
+ LoadTableResponse loadTableResponse, String snapshots) {
+ if (snapshots == null || snapshots.equalsIgnoreCase(SNAPSHOTS_ALL)) {
+ return loadTableResponse;
+ } else if (snapshots.equalsIgnoreCase(SNAPSHOTS_REFS)) {
+ TableMetadata metadata = loadTableResponse.tableMetadata();
+
+ Set<Long> referencedSnapshotIds =
+ metadata.refs().values().stream()
+ .map(SnapshotRef::snapshotId)
+ .collect(Collectors.toSet());
+
+ TableMetadata filteredMetadata =
+ metadata.removeSnapshotsIf(s ->
referencedSnapshotIds.contains(s.snapshotId()));
Review Comment:
The method is a bit confusing! This reads as `remove snapshots if a
snapshot's ID is not in referencedSnapshotIds`, you're right
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
