dimas-b commented on code in PR #1378:
URL: https://github.com/apache/polaris/pull/1378#discussion_r2051213819
##########
service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalog.java:
##########
@@ -1328,6 +1383,21 @@ public void doCommit(TableMetadata base, TableMetadata
metadata) {
String newLocation = writeNewMetadataIfRequired(base == null, metadata);
String oldLocation = base == null ? null : base.metadataFileLocation();
+ // TODO: we should not need to do this hack, but there's no other way to
modify
+ // currentMetadata / currentMetadataLocation
+ if (updateMetadataOnCommit) {
+ try {
+ tableMetadataField.set(metadata, newLocation);
+ unsafe.putObject(metadata, changesFieldOffset, new
ArrayList<MetadataUpdate>());
Review Comment:
I'm very uneasy about modifying private stuff in the `metadat` method
argument (especially its `final` fields).
Do I understand this correctly, that you guys talked about this offline and
this is still the easiest fix short of rewriting `IcebergCatalog` for direct
storage acces?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
