singhpk234 commented on code in PR #1378:
URL: https://github.com/apache/polaris/pull/1378#discussion_r2049397950
##########
polaris-core/src/main/java/org/apache/polaris/core/config/BehaviorChangeConfiguration.java:
##########
@@ -59,4 +59,14 @@ protected BehaviorChangeConfiguration(
.description("Whether or not to use soft values in the entity cache")
.defaultValue(false)
.buildBehaviorChangeConfiguration();
+
+ public static final BehaviorChangeConfiguration<Boolean>
TABLE_OPERATIONS_COMMIT_UPDATE_METADATA =
+ PolarisConfiguration.<Boolean>builder()
+ .key("TABLE_OPERATIONS_COMMIT_UPDATE_METADATA")
+ .description(
+ "If true, BasePolarisTableOperations should update the metadata
that is passed into"
+ + " `commit`, which means that future calls to `refresh` may
be able to skip a trip to"
+ + " object storage")
Review Comment:
Minor :
```suggestion
"If true, BasePolarisTableOperations should update the
metadata that is passed into"
+ " `commit`, and re:use it to skip a trip to"
+ " object storage to re:construct the committed metadata
again.")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
