flyrain commented on code in PR #1382:
URL: https://github.com/apache/polaris/pull/1382#discussion_r2049668801
##########
site/hugo.yaml:
##########
@@ -236,6 +236,9 @@ markup:
noHl: false
style: 'monokai'
tabWidth: 4
+ goldmark:
+ renderer:
+ unsafe: true
Review Comment:
I'm fine with this change. But I'd still prefer to avoid using html tag if
possible in markdown.
##########
site/content/in-dev/unreleased/access-control.md:
##########
@@ -84,11 +84,11 @@ principal roles. Likewise, a principal role can be granted
to one or more catalo
The following table displays examples of catalog roles that you might
configure in Polaris:
-| Example Catalog role | Description |
-| -----------------------| ----------- |
-| Catalog administrators | A role that has been granted multiple privileges
to emulate full access to the catalog.<br /><br />Principal roles that have
been granted this role are permitted to create, alter, read, write, and drop
tables in the catalog. |
-| Catalog readers | A role that has been granted read-only privileges to
tables in the catalog.<br /><br />Principal roles that have been granted this
role are allowed to read from tables in the catalog. |
-| Catalog contributor | A role that has been granted read and write access
privileges to all tables that belong to the catalog.<br /><br />Principal roles
that have been granted this role are allowed to perform read and write
operations on tables in the catalog. |
+| Example Catalog role | Description
|
+|
-----------------------|--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
+| Catalog administrators | A role that has been granted multiple privileges
to emulate full access to the catalog. <br/>Principal roles that have been
granted this role are permitted to create, alter, read, write, and drop tables
in the catalog. |
+| Catalog readers | A role that has been granted read-only privileges to
tables in the catalog. <br/>Principal roles that have been granted this role
are allowed to read from tables in the catalog.
|
+| Catalog contributor | A role that has been granted read and write access
privileges to all tables that belong to the catalog. <br/>Principal roles that
have been granted this role are allowed to perform read and write operations on
tables in the catalog. |
Review Comment:
+1 for spaces before `<br>`. The spaces in the end of each line seem
unnecessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
