mansehajsingh commented on code in PR #4:
URL: https://github.com/apache/polaris-tools/pull/4#discussion_r2048003492
##########
polaris-synchronizer/cli/src/main/java/org/apache/polaris/tools/sync/polaris/CreateOmnipotentPrincipalCommand.java:
##########
@@ -79,8 +93,17 @@ public class CreateOmnipotentPrincipalCommand implements
Callable<Integer> {
@Override
public Integer call() throws Exception {
- PolarisService polaris = options.buildService();
- AccessControlService accessControlService = new
AccessControlService(polaris);
+ polarisApiConnectionProperties.putIfAbsent("iceberg-write-access",
String.valueOf(withWriteAccess));
+
+ PolarisService polaris = PolarisServiceFactory.createPolarisService(
Review Comment:
No, you're right, this is a bit clunky. I've made it so that the individual
commands just pipe the property down and it is no longer implicitly implied by
the being the source or target.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
