gh-yzou commented on code in PR #1368:
URL: https://github.com/apache/polaris/pull/1368#discussion_r2043282845
##########
plugins/spark/v3.5/src/main/java/org/apache/polaris/spark/PolarisRESTCatalog.java:
##########
@@ -138,12 +152,51 @@ public void close() throws IOException {
@Override
public List<TableIdentifier> listGenericTables(Namespace ns) {
- throw new UnsupportedOperationException("listTables not supported");
+ if (!endpoints.contains(PolarisEndpoints.V1_LIST_GENERIC_TABLES)) {
+ return ImmutableList.of();
+ }
+
+ Map<String, String> queryParams = Maps.newHashMap();
+ ImmutableList.Builder<TableIdentifier> tables = ImmutableList.builder();
+ String pageToken = "";
Review Comment:
This is actually the same as iceberg
https://github.com/apache/iceberg/blob/main/core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java#L271
I think we should stay consistent on this part, so that once we have
pagination supported for iceberg client, this will work automatically.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
