dennishuo commented on code in PR #1305: URL: https://github.com/apache/polaris/pull/1305#discussion_r2043665933
########## polaris-core/src/main/java/org/apache/polaris/core/secrets/UserSecretReference.java: ########## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.polaris.core.secrets; + +import com.fasterxml.jackson.annotation.JsonProperty; +import com.google.common.base.MoreObjects; +import jakarta.annotation.Nonnull; +import jakarta.annotation.Nullable; +import java.util.HashMap; +import java.util.Map; +import java.util.Objects; + +/** + * Represents a "wrapped reference" to a user-owned secret that holds an identifier to retrieve + * possibly remotely-stored secret material, along with an open-ended "referencePayload" that is + * specific to an implementation of the secret storage and which is needed "unwrap" the actual + * secret in combination with whatever is stored in the remote secrets storage. Review Comment: Callers of methods on `UserSecretsManager` should not worry about what's inside `UserSecretReference`; that's why all the methods there just take a `UserSecretReference` object. The contents of `UserSecretRefeence` are for internal usage of each implementation of a `UserSecretsManager`. Ultimately, there are two different concepts that sound like they're getting mixed up in this comment thread: 1. Retrieval of content from a remote secret store 2. Reconstitution of sensitive secret material (2) may or may not be subsumed by (1) in the degenerate case, but these are the two distinct phases of loading a secret from ` UserSecretsManager`. URN is guaranteed to be a viable identifier of the remote secret store content. The full `UserSecretReference` is required to reconstituate the secret material. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
