dimas-b commented on code in PR #1274: URL: https://github.com/apache/polaris/pull/1274#discussion_r2021848847
########## polaris-core/src/main/java/org/apache/polaris/core/persistence/BasePersistence.java: ########## @@ -37,6 +37,11 @@ * defining the internal data model for Polaris, and which defines the basis for the RBAC model * provided by Polaris. * + * <p>Each method in this interface must be atomic, meaning that write operations must either fully + * succeed with all changes applied, or fail entirely without any side effects or partial updates. Review Comment: "without any side effects" is a very strong statement. The proposed Mongo impl. will not meet this requirement. How about "without any effects observable through this interface"? ########## polaris-core/src/main/java/org/apache/polaris/core/persistence/BasePersistence.java: ########## @@ -37,6 +37,11 @@ * defining the internal data model for Polaris, and which defines the basis for the RBAC model * provided by Polaris. * + * <p>Each method in this interface must be atomic, meaning that write operations must either fully + * succeed with all changes applied, or fail entirely without any side effects or partial updates. + * Read operations must return a consistent view of the data as it existed at a specific point in Review Comment: What is this "specific point in time"? Do all reads have to be based on the same point in time? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
