flyrain commented on code in PR #1258:
URL: https://github.com/apache/polaris/pull/1258#discussion_r2021403135
##########
quarkus/admin/build.gradle.kts:
##########
@@ -87,8 +87,8 @@ distributions {
contents {
from(runScript)
from(project.layout.buildDirectory.dir("quarkus-app"))
- from("../../NOTICE")
- from("../../LICENSE-BINARY-DIST").rename("LICENSE-BINARY-DIST",
"LICENSE")
+ from("distribution/NOTICE")
+ from("distribution/LICENSE")
Review Comment:
They are different. I am wondering if it's possible to provide a super set
so that, we don't have to to go to each individual binary module to generate a
different LICENSE and NOTICE, which adds a lot of burden for releasing. IIUC,
we potentially have to check each individual module as their jar files are
different, https://github.com/apache/polaris/pull/1258#issuecomment-2760810813.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
