snazy commented on code in PR #1228:
URL: https://github.com/apache/polaris/pull/1228#discussion_r2018356499
##########
service/common/src/main/java/org/apache/polaris/service/persistence/InMemoryPolarisMetaStoreManagerFactory.java:
##########
@@ -59,8 +58,9 @@ public InMemoryPolarisMetaStoreManagerFactory(
this.storageIntegration = storageIntegration;
}
- public void onStartup(RealmContextConfiguration realmContextConfiguration) {
- bootstrapRealmsAndPrintCredentials(realmContextConfiguration.realms());
+ @Override
+ public void initializeForService(@Nonnull List<String> realmIds, @Nonnull
String defaultRealmId) {
Review Comment:
> Also, why not call bootstrapRealms from QuarkusProducers?
I didn't want to change the behavior. It's only the in-memory one that
auto-bootstraps - and #1189. The EL one does not :shrug: - so I left it to the
implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
