flyrain commented on code in PR #1253:
URL: https://github.com/apache/polaris/pull/1253#discussion_r2017698553
##########
service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalog.java:
##########
@@ -1112,9 +1112,12 @@ private void validateNoLocationOverlap(
new ResolverPath(Arrays.asList(ns.levels()),
PolarisEntityType.NAMESPACE), ns));
ResolverStatus status = resolutionManifest.resolveAll();
if (!status.getStatus().equals(ResolverStatus.StatusEnum.SUCCESS)) {
- throw new IllegalStateException(
- "Unable to resolve sibling entities to validate location - could not
resolve"
- + status.getFailedToResolvedEntityName());
+ String message =
+ "Unable to resolve sibling entities to validate location - " +
status.getStatus();
+ if
(status.getStatus().equals(ResolverStatus.StatusEnum.ENTITY_COULD_NOT_BE_RESOLVED))
{
+ message += ". Entity = " + status.getFailedToResolvedEntityName();
Review Comment:
Minor: still like the previous message a bit more
```suggestion
message += "- could not resolve entity: " +
status.getFailedToResolvedEntityName();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
