eric-maynard commented on PR #1222: URL: https://github.com/apache/polaris/pull/1222#issuecomment-2749462705
Capturing the output, and maybe looking for `ModuleNotFoundError` sounds reasonable to me. Agreed that this will not cover all cases. `--repair` vs. `--upgrade`: I think there is significant ambiguity here as to whether you're taking this action on the service itself which I would like to avoid. e.g. does `--repair` repair my Polaris service somehow? Does `--upgrade` update the server to use the latest spec? There is also the question of intent. I understand that we are trying to provide a mechanism to just make the CLI work here, not to provide a mechanism to upgrade the CLI to the latest and greatest dependencies. Given these considerations, of the options presented I think `--repair` is still the _most_ clear. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
