stanislavkozlovski commented on code in PR #1246:
URL: https://github.com/apache/polaris/pull/1246#discussion_r2010148923


##########
polaris:
##########
@@ -28,6 +28,7 @@ if [ ! -d "${dir}"/polaris-venv ]; then
   python3 -m venv "${dir}"/polaris-venv
   . "${dir}"/polaris-venv/bin/activate
   pip install -r regtests/requirements.txt

Review Comment:
   I ack this is how we install dependencies here but I was hesitant to add 
these requirements to the `regtests` section since idk if they are actually 
necessary there.
   Perhaps creating a regular `requirements.txt` is in order?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to