liamzwbao commented on code in PR #1126:
URL: https://github.com/apache/polaris/pull/1126#discussion_r2008167264
##########
quarkus/service/src/test/java/org/apache/polaris/service/quarkus/catalog/BasePolarisCatalogTest.java:
##########
@@ -151,6 +151,8 @@ public Map<String, String> getConfigOverrides() {
"true",
"polaris.features.defaults.\"INITIALIZE_DEFAULT_CATALOG_FILEIO_FOR_TEST\"",
"true",
+ "polaris.features.defaults.\"ALLOW_OVERLAPPING_CATALOG_URLS\"",
Review Comment:
I initially added this because I thought `catalogName` was used by the
Polaris server to create a catalog. However, based on the information from
@dimas-b, `initCatalog` is only used to initialize a client-side object, and
the `catalogName` isn't actually needed. So, I’ve reduced the scope of
initCatalog to avoid creating a catalog in Polaris. As a result, this config is
no longer necessary, and I’ve removed it and updated the doc for `initiCatalog`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
