eric-maynard commented on code in PR #1124: URL: https://github.com/apache/polaris/pull/1124#discussion_r1987701126
########## polaris-core/src/main/java/org/apache/polaris/core/config/BehaviorChangeConfiguration.java: ########## @@ -0,0 +1,44 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.polaris.core.config; + +import java.util.Optional; + +/** + * Configurations for non-feature beheavior changes within Polaris. These configurations are not + * intended for use by end users and govern nuanced behavior changes and bugfixes. The + * configurations never expose user-facing catalog-level configurations. These configurations are + * not stable and may be removed at any time. + * + * @param <T> The type of the configuration + */ +public class BehaviorChangeConfiguration<T> extends PolarisConfiguration<T> { Review Comment: > checking for config values don't need to know what type the configuration is at runtime. Oh, I think the opposite. We should want the caller to have to acknowledge when they write logic that depends on an unstable flag. > I can just imagine cases where someone accidentally references one type and the config field is another Can you say more about this? Are you talking about a situation where the user misconfigures the application.properties? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
