dennishuo commented on PR #1135: URL: https://github.com/apache/polaris/pull/1135#issuecomment-2708017784
@dimas-b Okay, I inverted the method naming so that `BasePersistence` defines all-new `doFooAtomically` methods, while `TransactionalPersistence` keeps the existing `doFoo` method names. This way there is no change in which method needs to be called from `PolarisMetaStoreManagerImpl` and indeed no changes to the TreeMap/EclipseLink implementations. The nice thing here is the `AbstractTransactionalPersistence` just provides an adapter layer to make all those existing implementations also able to provide all the `Atomically` methods without them having to change at all. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
