flyrain commented on code in PR #924: URL: https://github.com/apache/polaris/pull/924#discussion_r1938168441
########## quarkus/defaults/src/main/resources/application.properties: ########## @@ -65,7 +65,7 @@ quarkus.micrometer.enabled=true quarkus.micrometer.export.prometheus.enabled=true quarkus.otel.enabled=true -quarkus.otel.sdk.disabled=false +quarkus.otel.sdk.disabled=true Review Comment: Should we turn `quarkus.otel.enabled` off as well? So that it disables all OpenTelemetry functionalities? Can we leave all valid configs in the comment section, so that users could figure out by themselves that what configurations to needed to set trace properly. ```suggestion quarkus.otel.sdk.disabled=true # quarkus.otel.enabled=true # quarkus.otel.sdk.disabled=false ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
