[
https://issues.apache.org/jira/browse/OPENNLP-1629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17893495#comment-17893495
]
ASF GitHub Bot commented on OPENNLP-1629:
-----------------------------------------
mawiesne opened a new pull request, #672:
URL: https://github.com/apache/opennlp/pull/672
Change
-
- updates opennlp-models dependency to 1.1
- adapts `DownloadUtil` to work with ud-models-1.1 release, adding 18 new
supported languages
- adapts existing JUnit tests accordingly to include and check the new model
files
- replaces content of `index.html` copy of the released model list (v 1.1.0)
for `DownloadParserTest`
Tasks
-
Thank you for contributing to Apache OpenNLP.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically main)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn
clean install at the root opennlp folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file in opennlp folder?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found in opennlp folder?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which
it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions for
build issues and submit an update to your PR as soon as possible.
> Update DownloadUtil to support more languages via new UD models
> ---------------------------------------------------------------
>
> Key: OPENNLP-1629
> URL: https://issues.apache.org/jira/browse/OPENNLP-1629
> Project: OpenNLP
> Issue Type: Sub-task
> Reporter: Richard Zowalla
> Assignee: Martin Wiesner
> Priority: Major
> Fix For: 2.4.1
>
>
> This class needs an update:
> [https://github.com/apache/opennlp/blob/ccca8ca5d5f95ae9af9b23126e6611058605bb17/opennlp-tools/src/main/java/opennlp/tools/util/DownloadUtil.java#L52]
>
> Note: We should allow the download of the v1.0 models, if requested by the
> user to maintain backward compatibility.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
