[
https://issues.apache.org/jira/browse/OPENNLP-1600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17879526#comment-17879526
]
ASF GitHub Bot commented on OPENNLP-1600:
-----------------------------------------
rzo1 opened a new pull request, #649:
URL: https://github.com/apache/opennlp/pull/649
Thank you for contributing to Apache OpenNLP.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically main)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn
clean install at the root opennlp folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file in opennlp folder?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found in opennlp folder?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which
it is rendered?
### Note:
This PR introduces a new `POSTagFormat#CUSTOM` which will disable the
automatic format mapping in `POSTaggerME`. In addition, it opens up the format
mapper variable to be `protected`, so people can override as needed.
fyi @reckart
> Ability to disable POS mapper
> -----------------------------
>
> Key: OPENNLP-1600
> URL: https://issues.apache.org/jira/browse/OPENNLP-1600
> Project: OpenNLP
> Issue Type: New Feature
> Components: POS Tagger
> Affects Versions: 2.4.0
> Reporter: Richard Eckart de Castilho
> Priority: Major
>
> Since version 2.4.0, the OpenNLP includes a mandatory POS tag mapper which
> either maps UD to Penn POS tags or vice versa.
> Now, this is a problem if you want to train a custom model on some arbitrary
> other POS tagset.
> It would be great if there was a was to disable the POS mapper.
> In fact, I would propose that POS mapping is turned off by default unless a
> POS mapper is manually supplied to the POS tagger - so stuff would remain
> backwards compatible.
> But at least being able to turn of the mapper and/or to provide a custom
> mapper would be appreciated.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
