[
https://issues.apache.org/jira/browse/OPENNLP-1599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17868374#comment-17868374
]
ASF GitHub Bot commented on OPENNLP-1599:
-----------------------------------------
rzo1 opened a new pull request, #641:
URL: https://github.com/apache/opennlp/pull/641
Thank you for contributing to Apache OpenNLP.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically main)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn
clean install at the root opennlp folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file in opennlp folder?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found in opennlp folder?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which
it is rendered?
### Note:
see https://github.com/apache/opennlp-models/pull/9
Rational is to avoid something like
```java
try {
final ClassPathModelLoader loader = new
ClassPathModelLoader();
final Set<ClassPathModelEntry> models = new
ClassgraphModelFinder().findModels(false);
for (ClassPathModelEntry entry : models) {
final ClassPathModel model = loader.load(entry);
if (model.getModelName().contains(element.getLang())) {
final TokenizerME tokenizer = new TokenizerME(new
TokenizerModel(new ByteArrayInputStream(model.model())));
tokenizers.put(element.getLang(), tokenizer);
return tokenizer;
}
}
} catch (IOException e) {
throw new PipelineExecutionException(e);
}
```
and just directly use `model.getLanguage()` (from a user perspective because
the model's name might not actually contain the actual language the model was
trained for).
> Add "model.language" to opennlp-models
> --------------------------------------
>
> Key: OPENNLP-1599
> URL: https://issues.apache.org/jira/browse/OPENNLP-1599
> Project: OpenNLP
> Issue Type: Improvement
> Components: Models
> Reporter: Richard Zowalla
> Assignee: Richard Zowalla
> Priority: Major
> Fix For: 2.4.1
>
>
> I just integrated opennlp-models via Maven / Classpath in my application.
> While doing so, I noticed, that there is no simple way to get the language of
> the related model without loading it and checking the models name.
>
> Therefore, it would be neat to add a new property key "model.language" to
> retrieve the bootstraped language identifier to ease user consumption.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
