[ 
https://issues.apache.org/jira/browse/OPENNLP-1595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17866047#comment-17866047
 ] 

ASF GitHub Bot commented on OPENNLP-1595:
-----------------------------------------

rzo1 commented on code in PR #637:
URL: https://github.com/apache/opennlp/pull/637#discussion_r1677748052


##########
opennlp-tools/src/main/java/opennlp/tools/ml/maxent/GISModel.java:
##########
@@ -207,7 +206,7 @@ static double[] eval(Context[] context, float[] values, 
double[] prior,
 
   @Override
   public int hashCode() {

Review Comment:
   Can be removed if we just do `super.hashCode()` ?





> Clear methods that are identical to their super methods
> -------------------------------------------------------
>
>                 Key: OPENNLP-1595
>                 URL: https://issues.apache.org/jira/browse/OPENNLP-1595
>             Project: OpenNLP
>          Issue Type: Improvement
>    Affects Versions: 2.3.3
>            Reporter: Martin Wiesner
>            Assignee: Martin Wiesner
>            Priority: Trivial
>             Fix For: 2.4.0
>
>
> Code inspection reveals several classes that have identical method signature 
> and method body. Such methods a superfluous and can be removed.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to