[
https://issues.apache.org/jira/browse/OPENNLP-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17864526#comment-17864526
]
ASF GitHub Bot commented on OPENNLP-1593:
-----------------------------------------
mawiesne opened a new pull request, #156:
URL: https://github.com/apache/opennlp-sandbox/pull/156
Change
-
- provides JUnit tests for LexicalChainingSummarizer and TextRankSummarizer
- improves the existing code so that summarization works, fixes a bug in
LexicalChainingSummarizer#summarize
- improves the code quality
- adds JavaDoc where possible
Tasks
-
Thank you for contributing to Apache OpenNLP.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically main)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via `mvn
clean install` at the root opennlp-sandbox folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](https://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file in opennlp-sandbox folder?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found in opennlp-sandbox folder?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which
it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions for
build issues and submit an update to your PR as soon as possible.
> Provide tests for all Summarizer implementations
> ------------------------------------------------
>
> Key: OPENNLP-1593
> URL: https://issues.apache.org/jira/browse/OPENNLP-1593
> Project: OpenNLP
> Issue Type: Test
> Components: Summarizer
> Affects Versions: 2.3.3
> Reporter: Martin Wiesner
> Assignee: Martin Wiesner
> Priority: Minor
> Fix For: 2.4.0
>
>
> While resolving OPENNLP-1592, it was discovered that tests were missing for
> the LexicalChainingSummarizer and the TextRankSummarizer.
> Aims:
> * Provide more tests for the aforementioned classes
> * Extract common test setup for summarizer classes (all 3 impls)
> * Improve implementation
> * Enhance JavaDoc further
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
