[
https://issues.apache.org/jira/browse/OPENNLP-1592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17864218#comment-17864218
]
ASF GitHub Bot commented on OPENNLP-1592:
-----------------------------------------
mawiesne opened a new pull request, #154:
URL: https://github.com/apache/opennlp-sandbox/pull/154
Change
-
- provides a minimal set of JUnit tests for MetaSummarizer
- improves the existing code so that summarization works (again)
- improves the code quality
- adds JavaDoc where possible.
Tasks
-
Thank you for contributing to Apache OpenNLP.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically main)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via `mvn
clean install` at the root opennlp-sandbox folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](https://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file in opennlp-sandbox folder?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found in opennlp-sandbox folder?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which
it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions for
build issues and submit an update to your PR as soon as possible.
> Provide tests for MetaSummarizer
> --------------------------------
>
> Key: OPENNLP-1592
> URL: https://issues.apache.org/jira/browse/OPENNLP-1592
> Project: OpenNLP
> Issue Type: Test
> Components: Summarizer
> Affects Versions: 2.3.3
> Reporter: Martin Wiesner
> Assignee: Martin Wiesner
> Priority: Major
> Fix For: 2.4.0
>
>
> The summarizer (sandbox) component lacks Tests for MetaSummarizer.java.
> Currently, only an orphaned main method exists in the corresponding class.
> Therefore, it is much desirable to have a fix set of tests that demonstrate
> this class actually works (Note: it doesn't as is).
> Aims:
> * Provide a minimal set of tests for MetaSummarizer
> * Improve the existing code so that summarization works (again)
> * Improve the code quality
> * Add JavaDoc where possible.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
