[
https://issues.apache.org/jira/browse/OPENNLP-1564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850471#comment-17850471
]
ASF GitHub Bot commented on OPENNLP-1564:
-----------------------------------------
rzo1 opened a new pull request, #603:
URL: https://github.com/apache/opennlp/pull/603
Thank you for contributing to Apache OpenNLP.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically main)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn
clean install at the root opennlp folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file in opennlp folder?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found in opennlp folder?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which
it is rendered?
### Note:
Updates some missed `PENN` format cases in the evaluation test data. In
addition, if `POSTaggerNameFeatureGenerator` is used for NameFinder (i.e.
defined via XML), we only get a POSModel and need to guess the format of it
before creating the `POSTagger`. Therefore, I updated the mapper with a static
method for guessing this type based on a given POSModel. This might be useful
for other cases as well.
Sadly, ASF Jenkins is currently broken, so we cannot trigger a manual run,
see https://issues.apache.org/jira/browse/INFRA-25828
> Fix Evaluation Tests after POSFormat Change
> -------------------------------------------
>
> Key: OPENNLP-1564
> URL: https://issues.apache.org/jira/browse/OPENNLP-1564
> Project: OpenNLP
> Issue Type: Task
> Reporter: Richard Zowalla
> Assignee: Richard Zowalla
> Priority: Major
> Fix For: 2.3.4, 2.4.0
>
>
> ERROR] Failures:
> [ERROR] ConllXPosTaggerEval.evalDanishMaxentGis:133->eval:79 expected:
> <0.9504442925495558> but was: <0.0>
> [ERROR] ConllXPosTaggerEval.evalDanishMaxentQn:144->eval:79 expected:
> <0.9564251537935748> but was: <0.0>
> [ERROR] ConllXPosTaggerEval.evalSwedishMaxentGis:200->eval:79 expected:
> <0.9248585572842999> but was: <0.0>
> [ERROR] ConllXPosTaggerEval.evalSwedishMaxentQn:211->eval:79 expected:
> <0.9377652050919377> but was: <0.0>
> [ERROR] OntoNotes4NameFinderEval.evalAllTypesWithPOSNameFinder:152
> expected: <0.8070226153653437> but was: <0.8060021642728011>
> [ERROR] OntoNotes4PosTaggerEval.evalEnglishMaxentTagger:79->crossEval:65
> expected: <0.969345319453096> but was: <1.5460660461489513E-4>
> [ERROR] SourceForgeModelEval.evalChunkerModel:344 expected:
> <304922886851384639120257052245406261332> but was:
> <85416056838725341441074840387786758951>
> [ERROR] SourceForgeModelEval.evalMaxentModel:376->evalPosModel:368
> expected: <231995214522232523777090597594904492687> but was:
> <90112530006040278703441476599716290769>
> [ERROR] SourceForgeModelEval.evalPerceptronModel:384->evalPosModel:368
> expected: <209440430718727101220960491543652921728> but was:
> <256369615778494816584749939613105809001>
> [INFO]
> [ERROR] Tests run: 1040, Failures: 9, Errors: 0, Skipped: 3
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
