[
https://issues.apache.org/jira/browse/OPENNLP-589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836942#comment-17836942
]
ASF GitHub Bot commented on OPENNLP-589:
----------------------------------------
mawiesne opened a new pull request, #596:
URL: https://github.com/apache/opennlp/pull/596
Change
-
- adjusts input format in RealBasicEventStream to match the other
EventStream's format expectations (consistency!)
- adds AbstractEventStreamTest as common base for all related event stream
classes
- adds new RealBasicEventStreamTest to cover the consistency checks
- adjusts existing ScaleDoesntMatterTest to match the (consistent) format
- adds further test cases for yet untested methods and/or branches
(coverage++)
- improves existing JavaDoc
- adds further JavaDoc along the path
Tasks
-
Thank you for contributing to Apache OpenNLP.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically main)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn
clean install at the root opennlp folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file in opennlp folder?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found in opennlp folder?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which
it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions for
build issues and submit an update to your PR as soon as possible.
> Text format of Events inconsistent across different implementations of
> EventStreamReaders
> -----------------------------------------------------------------------------------------
>
> Key: OPENNLP-589
> URL: https://issues.apache.org/jira/browse/OPENNLP-589
> Project: OpenNLP
> Issue Type: Bug
> Components: Machine Learning
> Affects Versions: maxent-3.0.3, 2.0.0, 2.1.0, 2.2.0, 2.3.0
> Reporter: Marcin Junczys-Dowmunt
> Assignee: Martin Wiesner
> Priority: Minor
> Fix For: 2.3.3
>
>
> BasicEventStream expects events to be written to text files as:
> context1 context2 context3 ... outcome
> FileEventStream expects events to be written to text files as:
> outcome context1 context2 context3 ...
> toString() of Event creates:
> outcome [context1 context2 context3 ...] (note the square brackets, which are
> part of context predicates when breaking on spaces).
> This is highly confusing and took me some time to understand. I guess this
> should be unified?
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
