[
https://issues.apache.org/jira/browse/OPENNLP-1446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17800527#comment-17800527
]
ASF GitHub Bot commented on OPENNLP-1446:
-----------------------------------------
kinow commented on code in PR #113:
URL: https://github.com/apache/opennlp-sandbox/pull/113#discussion_r1436543081
##########
opennlp-wsd/src/test/java/opennlp/tools/disambiguator/WSDTest.java:
##########
@@ -47,95 +46,62 @@
* and then the computed model is used to predict sentences
* from the training sentences.
*/
-
-class WSDTester {
- // TODO write more tests
- // TODO modify when we fix the parameter model
-
- static String modelsDir = "src/test/resources/models/";
- static String trainingDataDirectory =
"src/test/resources/supervised/models/";
+// TODO write more tests
+// TODO modify when we fix the parameter model
Review Comment:
:+1: :point_up:
##########
corpus-server/corpus-server-connector/src/test/java/org/apache/opennlp/corpus_server/connector/CSCasWriterTest.java:
##########
@@ -77,7 +76,6 @@ void testCasWrite() {
cas.setDocumentText("this cas needs to be stored");
casConsumer.processCas(cas);
} catch (Exception e) {
- e.printStackTrace();
Review Comment:
:+1:
##########
summarizer/src/test/java/opennlp/summarization/lexicalchaining/LexChainTest.java:
##########
@@ -101,7 +102,7 @@ void testGetRelation() {
assertEquals(WordRelation.MED_RELATION, rel2.relation);
assertEquals(WordRelation.MED_RELATION, rel3.relation);
} catch (Exception e) {
- e.printStackTrace();
+ fail(e.getLocalizedMessage());
Review Comment:
:+1: or just let it raise the exception with the whole stack trace.
> Investigate why LeskEvaluatorTest and MFSEvaluatorTest fail while parsing
> 'EnglishLS.train'
> -------------------------------------------------------------------------------------------
>
> Key: OPENNLP-1446
> URL: https://issues.apache.org/jira/browse/OPENNLP-1446
> Project: OpenNLP
> Issue Type: Task
> Components: wsd
> Affects Versions: 2.1.0
> Reporter: Martin Wiesner
> Assignee: Martin Wiesner
> Priority: Minor
> Fix For: 2.3.2
>
> Time Spent: 4h
> Remaining Estimate: 0h
>
> The _LeskEvaluatorTest_ & _MFSEvaluatorTest_ in the _opennlp-wsd_ sandbox
> component both fail parsing the 'EnglishLS.train' file. The data is kept
> original, downloaded from
> {{[https://web.eecs.umich.edu/~mihalcea/senseval/senseval3/data.html]}}
> h4. {{Aims:}}
> * Investigate what causes the xml parsing to fail
> * Fix it and make both existing tests pass
> * Optional: Improve the existing test code to be more strict.
> h4. Note:
> The test setup to reproduce this is on a branch and to be merged into the
> main branch.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
