[
https://issues.apache.org/jira/browse/OPENNLP-1454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17714743#comment-17714743
]
ASF GitHub Bot commented on OPENNLP-1454:
-----------------------------------------
reckart commented on PR #101:
URL: https://github.com/apache/opennlp-sandbox/pull/101#issuecomment-1516908800
> introduces log4j-2.x as (managed) runtime binding for slj4j in
opennlp-similarity
I didn't see the binding being added in the runtime scope in the changes -
however, it should not be added as a runtime dependency because afaik runtime
dependencies are transitive - and logging implementations should never be part
of the transitive dependency graph.
> Convert System.out statements to debug logging statements in
> 'opennlp-similarity' sandbox component
> ---------------------------------------------------------------------------------------------------
>
> Key: OPENNLP-1454
> URL: https://issues.apache.org/jira/browse/OPENNLP-1454
> Project: OpenNLP
> Issue Type: Task
> Components: Similarity
> Affects Versions: 2.1.0
> Reporter: Martin Wiesner
> Assignee: Martin Wiesner
> Priority: Minor
>
> In several classes of the 'opennlp-similarity' sandbox component, commented
> System.out statements exist that have a debug statement flavor. Yet, in tests
> and at runtime those spam the console quite heavily. That's why those have
> been commented out during the compatibility migration towards tools version
> 2.1.x conducted for all sandbox components.
> The aim of that issue is to convert those spammy log behavior by making use
> of the slf4j-api. The code contains the spots marked with a TODO notice and
> this issue number for which a switch to a logging framework with "trace" or
> "debug" levels could be considered.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
