[
https://issues.apache.org/jira/browse/OPENNLP-1340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17653697#comment-17653697
]
ASF GitHub Bot commented on OPENNLP-1340:
-----------------------------------------
rzo1 opened a new pull request, #481:
URL: https://github.com/apache/opennlp/pull/481
Thank you for contributing to Apache OpenNLP.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically main)?
- x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn
clean install at the root opennlp folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file in opennlp folder?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found in opennlp folder?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which
it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions for
build issues and submit an update to your PR as soon as possible.
> Get the probability for a sequence without copying the probabilities
> --------------------------------------------------------------------
>
> Key: OPENNLP-1340
> URL: https://issues.apache.org/jira/browse/OPENNLP-1340
> Project: OpenNLP
> Issue Type: Wish
> Components: POS Tagger
> Affects Versions: 1.9.3
> Reporter: Reece H. Dunn
> Assignee: Richard Zowalla
> Priority: Trivial
> Labels: easyfix
>
> The "opennlp.tools.util.Sequence" class has a "getOutcomes" method that
> returns the outcomes as the underlying list without copying the data.
> However, the "getProbs" method returns the probabilities as an array copy of
> the underlying probabilities list.
> It would be useful to have the following accessor methods to avoid the copy
> (and an accessor for the outcomes for API consistency):
> {code:java}
> public int getSize() {
> return outcomes.size();
> }
> public String getOutcome(int index) {
> return outcomes.get(index);
> }
> public double getProb(int index) {
> return probs.get(index);
> }
> {code}
> The motivation is that I want to convert the "POSTagger.topKSequences" to a
> "Map<String, Double>", in addition to locating the highest probability tag in
> the result.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
