[ 
https://issues.apache.org/jira/browse/OPENNLP-1432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17653468#comment-17653468
 ] 

ASF GitHub Bot commented on OPENNLP-1432:
-----------------------------------------

mawiesne commented on code in PR #478:
URL: https://github.com/apache/opennlp/pull/478#discussion_r1059797078


##########
opennlp-tools/src/main/java/opennlp/tools/util/wordvector/Glove.java:
##########
@@ -29,6 +29,9 @@
 import opennlp.tools.util.java.Experimental;
 
 /**
+ *
+ * GloVe is an unsupervised learning algorithm for obtaining vector 
representations for words.
+ * Details are found on this <a 
href="https://nlp.stanford.edu/projects/glove/";> web site</a>.

Review Comment:
   Will fix, once the "CC0" topic is discussed and decided.





> Provide tests for opennlp.tools.util.wordvector package
> -------------------------------------------------------
>
>                 Key: OPENNLP-1432
>                 URL: https://issues.apache.org/jira/browse/OPENNLP-1432
>             Project: OpenNLP
>          Issue Type: Test
>          Components: Build, Packaging and Test, word vectors
>    Affects Versions: 2.1.0
>            Reporter: Martin Wiesner
>            Assignee: Martin Wiesner
>            Priority: Minor
>             Fix For: 2.1.1
>
>
> With OPENNLP-1144, support for word vectors was introduced. However, no JUnit 
> tests were provided with that implementation.
> Aims
>  * Provide tests for _opennlp.tools.util.wordvector_ package
>  * Raise code coverage for the corresponding package
>  * Improve JavaDoc along the way



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to