[
https://issues.apache.org/jira/browse/OPENNLP-1358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17653190#comment-17653190
]
ASF GitHub Bot commented on OPENNLP-1358:
-----------------------------------------
rzo1 opened a new pull request, #476:
URL: https://github.com/apache/opennlp/pull/476
# What does this PR do?
Tests are not failing on Windows anymore. This PR adds build support for
Windows (latest = Server 2022) and adjusts test cases (if needed) to be run on
GH actions CI.
- Adds CI for Windows (latest = Server 2022, similar to Windows 11) to be
able to build / test with Windows
- Unifies how line endings are handled by git via `.gitattributes` as we
have a checkstyle rule in place which prohibits the use of CRLF (checkstyle
will fail a build on Windows if `git` isn't configured accordingly)
- **Converts** line endings from CRLF to LF (according to supplied
`.gitattributes`, see
https://docs.github.com/en/get-started/getting-started-with-git/configuring-git-to-handle-line-endings)
via `git add --renormalize .`
- Workarounds https://github.com/junit-team/junit5/issues/2811 (`@TempDir`
created folders cannot be deleted on Windows Server 2022)
- Removes Coveralls as there is no Jacoco support at the moment (so the step
isn't useful anymore): https://github.com/coverallsapp/github-action/issues/22
Matrix build is now happy:
https://github.com/rzo1/opennlp/actions/runs/3809019320
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically main)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn
clean install at the root opennlp folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file in opennlp folder?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found in opennlp folder?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which
it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions for
build issues and submit an update to your PR as soon as possible.
> Failing tests on Windows 11 and Java 17
> ---------------------------------------
>
> Key: OPENNLP-1358
> URL: https://issues.apache.org/jira/browse/OPENNLP-1358
> Project: OpenNLP
> Issue Type: Task
> Affects Versions: 1.9.4
> Environment: Windows with Java 17
> Reporter: Jeff Zemerick
> Assignee: Richard Zowalla
> Priority: Minor
>
> The following tests are failing on Windows 11 and Java 17 build. The tests
> pass on Ubuntu 20.04 with Java 17.
> [ERROR] Failures:
> [ERROR] BratDocumentParserTest.testParse:55 expected:<3> but was:<1>
> [ERROR] BratDocumentTest.testDocumentWithEntitiesParsing:47
> [ERROR] BratNameSampleStreamTest.readNoOverlap:65 expected:<8> but was:<7>
> [ERROR] BratNameSampleStreamTest.readOverlapFail Expected exception:
> java.lang.RuntimeException
> [INFO]
> [ERROR] Tests run: 784, Failures: 4, Errors: 0, Skipped: 0
> Apache Maven 3.8.5 (3599d3414f046de2324203b78ddcf9b5e4388aa0)
> Maven home: C:\Program Files\apache-maven
> Java version: 17.0.2, vendor: Amazon.com Inc., runtime: C:\Program
> Files\Amazon Corretto\jdk17.0.2_8
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 11", version: "10.0", arch: "amd64", family: "windows"
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
