[
https://issues.apache.org/jira/browse/OPENNLP-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17651200#comment-17651200
]
ASF GitHub Bot commented on OPENNLP-1419:
-----------------------------------------
rzo1 merged PR #465:
URL: https://github.com/apache/opennlp/pull/465
> Enhance Tests and JavaDoc in opennlp.morfologik package
> -------------------------------------------------------
>
> Key: OPENNLP-1419
> URL: https://issues.apache.org/jira/browse/OPENNLP-1419
> Project: OpenNLP
> Issue Type: Improvement
> Components: Morfologik Addon
> Affects Versions: 2.1.0
> Reporter: Martin Wiesner
> Assignee: Martin Wiesner
> Priority: Minor
> Fix For: 2.1.1
>
>
> The (JUnit) tests in _opennlp.morfologik_ package show an anti-pattern of
> test classes relying on each other, that is: code is mixed around and feels
> near to spaghetti. Moreover, the naming of some of the existing test classes
> is not consistent with the classes under test. This should both be fixed and
> improved.
> The JavaDoc the _opennlp.morfologik_ package shows several inconsistencies
> and missing descriptions. Moreover, several typos are present that need
> sanitizing, especially in class names.
> Both aspects need a cure and the package some additions to provide more
> clarity for readers of the API and devs with respect to understanding the
> test setup correctly.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
