[
https://issues.apache.org/jira/browse/OPENNLP-1369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17534010#comment-17534010
]
ASF GitHub Bot commented on OPENNLP-1369:
-----------------------------------------
kinow commented on code in PR #417:
URL: https://github.com/apache/opennlp/pull/417#discussion_r868413898
##########
opennlp-tools/src/main/java/opennlp/tools/util/model/BaseModel.java:
##########
@@ -574,6 +574,10 @@ public final void serialize(OutputStream out) throws
IOException {
Object artifact = entry.getValue();
+ if (artifact == null) {
+ continue;
+ }
+
Review Comment:
Would it be possible to have a test for this?
> NPE when serializing a TokenNameFinder model trained with
> POSTaggerNameFeatureGeneratorFactory
> ----------------------------------------------------------------------------------------------
>
> Key: OPENNLP-1369
> URL: https://issues.apache.org/jira/browse/OPENNLP-1369
> Project: OpenNLP
> Issue Type: Bug
> Reporter: Lucas Avanço
> Priority: Major
>
> There is an issue of null pointer when trying to serialize a TokenNameFinder
> model trained using as one of feature generators
> POSTaggerNameFeatureGeneratorFactory.
> In this method
> opennlp.tools.util.model.{*}BaseModel#serialize{*}(java.io.OutputStream)
> there is a for which iterates over the artifactMap of the POS-model that must
> be serialized together, but a NPE occurs because *generator.featuregen* is
> not found inside of *pt-pos-perceptron.zip*
>
> <generator
> class="opennlp.tools.util.featuregen.WindowFeatureGeneratorFactory">
> <int name="prevLength">2</int>
> <int name="nextLength">2</int>
> <generator
> class="opennlp.tools.util.featuregen.POSTaggerNameFeatureGeneratorFactory">
> <str name="model">pt-pos-perceptron.zip</str>
> </generator>
> </generator>
>
> This is the POS-tagger model used:
> http://opennlp.sourceforge.net/models-1.5/pt-pos-perceptron.bin
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
