pvillard31 opened a new pull request, #11073: URL: https://github.com/apache/nifi/pull/11073
# Summary NIFI-15765 - Fix flaky tests on FlowSynchronizationIT 1st change - `setupClient()` at the start of teardown. Tests like `testSensitivePropertiesInherited` call `switchClientToNode(2)` and leave the client pointed at node 2. Teardown then sends health checks and `destroyFlow()` calls to node 2 instead of the coordinator. If node 2 is in any transient state (just reconnected, still finishing initialization), the `getCluster()` endpoint rejects the request with "Only a node connected to a cluster can process the request." Resetting the client to node 1 (the coordinator) ensures teardown always talks to the stable node. (node 1 is a better choice than node 2 because tests routinely disconnect/reconnect/restart node 2, while node 1 is always left running and connected) 2nd change - try-catch around health checks. Even with the client reset to node 1, there could be scenarios where node 1 itself can't respond (e.g., both nodes are briefly unhealthy). The try-catch ensures the instance always gets poisoned rather than silently reused in a broken state. This effectively avoids a cascade of failures like in the example reported in the JIRA. # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000` - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000` - [ ] Pull request contains [commits signed](https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits) with a registered key indicating `Verified` status ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `./mvnw clean install -P contrib-check` - [ ] JDK 21 - [ ] JDK 25 ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
