pvillard31 commented on code in PR #11066:
URL: https://github.com/apache/nifi/pull/11066#discussion_r3005053575
##########
nifi-extension-bundles/nifi-aws-bundle/nifi-aws-regions/src/test/java/org/apache/nifi/processors/aws/region/RegionUtilTest.java:
##########
@@ -106,4 +108,12 @@ void testIsDynamicRegionWithDynamicCustomRegion() {
assertTrue(RegionUtil.isDynamicRegion(propertyContext));
}
+
+ @Test
+ void testRegionDisplayNameOrdering() {
+ final List<AllowableValue> allowableRegionValues =
REGION.getAllowableValues();
+
+ assertEquals("Africa (Cape Town)",
allowableRegionValues.getFirst().getDisplayName());
Review Comment:
I agree this is unlikely but this test might fail when we upgrade the
dependency in AWS SDK and they add a new region. Honestly, I'm fine without a
unit test for this change. If you can share a screenshot of the before/after in
the UI that's good enough with me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
