martinzink commented on PR #2139:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2139#issuecomment-4110452786
> Is the new parameter ever used as anything other than a boolean check
(root is not null)?
currently just for boolean check, but the caller functions share the name
and usually pass this argument so it made sense to pass this instead of
creating a new concept (has_root_group: bool)
e.g.
```
void MetricsPublisherStore::loadMetricNodes(core::ProcessGroup* root) {
response_node_loader_->setNewConfigRoot(root);
for (const auto& [name, publisher]: metrics_publishers_) {
publisher->loadMetricNodes();
}
}
void MetricsPublisherStore::loadMetricNodes(core::ProcessGroup* root) {
response_node_loader_->setNewConfigRoot(root);
for (const auto& [name, publisher]: metrics_publishers_) {
publisher->loadMetricNodes(root);
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
